config2setopts: make --capath work in proxy disabled builds#21063
Closed
config2setopts: make --capath work in proxy disabled builds#21063
Conversation
Follow-up to 95e8515 Spotted by Codex Security
There was a problem hiding this comment.
Pull request overview
Updates the curl tool’s config-to-setopt translation so --capath no longer fails when built against a libcurl that has proxy support disabled (where proxy-specific TLS options may return CURLE_UNKNOWN_OPTION / CURLE_NOT_BUILT_IN).
Changes:
- Treat
CURLOPT_PROXY_CAPATHreturningCURLE_NOT_BUILT_IN/CURLE_UNKNOWN_OPTIONas ignorable and continue. - Emit a warning when proxy CA path setting is unsupported and clear the error to avoid aborting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #21063 at fff46570: Test 671 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 95e8515
Spotted by Codex Security