Closed
Conversation
When the path is exactly one byte, a single slash. Extended test 1560 to verify. Found by Codex Security
There was a problem hiding this comment.
Pull request overview
Fixes an edge case in the URL API where file:/// (path length exactly 1 byte: /) was not handled correctly, and extends the existing URL parsing test coverage to lock in the behavior.
Changes:
- Adjust
lib/urlapi.cpath handling to retain a 1-byte path for thefilescheme (sofile:///remains valid/serializable). - Plumb a
file-scheme indicator intohandle_path()so the minimum stored path length differs forfilevs other schemes. - Extend
tests/libtest/lib1560.cwith newfile:///and dot-segment normalization cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/urlapi.c |
Ensures file-scheme paths of length 1 ("/") are preserved so file:/// can be parsed and re-serialized safely. |
tests/libtest/lib1560.c |
Adds regression cases for file:/// and file:///./ / file:///.' normalization to file:///. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Mar 25, 2026
When the path is exactly one byte, a single slash. Extended test 1560 to verify. Found by Codex Security Closes curl#21070
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the path is exactly one byte, a single slash.
Extended test 1560 to verify.
Found by Codex Security