tool_getparam: use correct free function for libcurl memory#21075
Closed
tool_getparam: use correct free function for libcurl memory#21075
Conversation
Memory returned from curl_easy_escape() should be fred with curl_free() to avoid surprises. Follow-up to f37840a Spotted by Codex Security
There was a problem hiding this comment.
Pull request overview
This PR fixes an allocator mismatch in the curl tool by ensuring that the string returned from curl_easy_escape() is not later freed with the tool’s curlx_free/tool_safefree, which could be problematic when libcurl is configured with custom allocators.
Changes:
- Duplicate
curl_easy_escape()output into tool-owned memory (curlx_strdup) and free the original withcurl_free(). - Ensure the returned pointer from
data_urlencode()is consistently safe to free with the tool’s normal cleanup paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory returned from curl_easy_escape() should be fred with curl_free() to avoid surprises.
Follow-up to f37840a
Spotted by Codex Security