url: do not reuse a non-tls starttls connection if new requires TLS#21082
Closed
url: do not reuse a non-tls starttls connection if new requires TLS#21082
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates connection reuse matching in lib/url.c to avoid reusing an existing clear-text connection for STARTTLS-style protocols when the new transfer requires TLS, preventing an unsafe/incompatible reuse.
Changes:
- Add a
req_tlsflag to the connection-match struct to represent “TLS is required for a clear-text STARTTLS scheme”. - Reject reuse of non-SSL connections when
req_tlsis set, even if the scheme itself is non-SSL (STARTTLS case). - Initialize
req_tlsfromdata->set.use_sslduring reuse candidate selection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.