Closed
Conversation
On any `Curl_rlimit_start()` the rate limit needs to reset its values before calculating the effective step duration and adjust the tokens/burst per step. Add two fields to the struct to remember the original values.
Contributor
Author
|
@JimFuller-RedHat this should address your observed debug assertion. |
Contributor
|
LGTM |
bagder
approved these changes
Mar 24, 2026
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Mar 25, 2026
On any `Curl_rlimit_start()` the rate limit needs to reset its values before calculating the effective step duration and adjust the tokens/burst per step. Add two fields to the struct to remember the original values. Closes curl#21086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On any
Curl_rlimit_start()the rate limit needs to reset its values before calculating the effective step duration and adjust the tokens/burst per step.Add two fields to the struct to remember the original values.