temp files: inherit permissions only for owner#21092
Closed
icing wants to merge 1 commit intocurl:masterfrom
Closed
temp files: inherit permissions only for owner#21092icing wants to merge 1 commit intocurl:masterfrom
icing wants to merge 1 commit intocurl:masterfrom
Conversation
When creating a temp file in order to later replace an original, copying over the existing permissions can not be considered safe when the user running libcurl is not the owner of the existing file.
Contributor
Author
|
This could cause breakage in some weird use cases where different uid processes try to manage a shared resource file. It sounds like a strange operation mode, though. But applications have been known to be "inventive" in the past... |
vszakats
reviewed
Mar 25, 2026
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Apr 7, 2026
When creating a temp file in order to later replace an original, copying over the existing permissions can not be considered safe when the user running libcurl is not the owner of the existing file. Closes curl#21092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a temp file in order to later replace an original, copying over the existing permissions can not be considered safe when the user running libcurl is not the owner of the existing file.