md4, md5: switch to wolfCrypt API in wolfSSL builds#21093
Closed
vszakats wants to merge 9 commits intocurl:masterfrom
Closed
md4, md5: switch to wolfCrypt API in wolfSSL builds#21093vszakats wants to merge 9 commits intocurl:masterfrom
vszakats wants to merge 9 commits intocurl:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates curl’s MD4/MD5 implementations for wolfSSL builds to use the native wolfCrypt API instead of the OpenSSL-compatibility layer, aligning behavior with other wolfCrypt-backed hashes in the codebase.
Changes:
- MD5: remove wolfSSL OpenSSL-compat header usage and switch to
<wolfssl/wolfcrypt/md5.h>+wc_*APIs. - MD4: switch wolfSSL implementation to
<wolfssl/wolfcrypt/md4.h>and add thin wrappers matching the existing MD4_Init/Update/Final call pattern.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/md5.c | Switch wolfSSL MD5 backend from OpenSSL-compat API to wolfCrypt wc_Md5 APIs. |
| lib/md4.c | Switch wolfSSL MD4 backend to wolfCrypt and wrap wc_* calls behind MD4_Init/Update/Final. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the OpenSSL-like compatibility interface, and syncing with other
hashes, when building with wolfSSL.
Also: stop stomping on OpenSSL public MD4 symbols. This makes the wolfSSL
coexist workaround unnecessary, while also syncing up with MD5 sources.
After this patch the only remaining reference to wolfSSL's OpenSSL
compatibility layer is in
lib/curl_ntlm_core.c.