New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "file:" URL handling in url.c #2110

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@phluid61
Contributor

phluid61 commented Nov 24, 2017

url: updates "file:" URI handling in url.c

  • LOTS of comment updates (especially about RFC 8089)
  • explicit error for SMB shares (e.g. file:////share/path/file) with test
  • more strict handling of authority (i.e. //hostname)
  • now accepts dodgy old C| drive letters
  • more precise handling of drive letters in and out of Windows
    (especially recognising both file:c:/ and file:/c:/)
  • new tests for file:path and file://127.0.0.1/path URLs

phluid61 added some commits Nov 24, 2017

update "file:" URL handling in url.c
* LOTS of comment updates
* explicit error for SMB shares (e.g. "file:////share/path/file")
* more strict handling of authority (i.e. "//localhost/")
* now accepts dodgy old "C:|" drive letters
* more precise handling of drive letters in and out of Windows
  (especially recognising both "file:c:/" and "file:/c:/")
shorten long lines
for `make checksrc`
@phluid61

This comment has been minimized.

Show comment
Hide comment
@phluid61

phluid61 Nov 24, 2017

Contributor

TODO: write non-Windows unit tests to ensure that these all fail with CURLE_URL_MALFORMAT "File drive letters are only accepted in MSDOS/Windows.":

  • file:c:/
  • file:/c:/
  • file:///c:/
  • file:c|/
  • file:/c|/
  • file:///c|/
Contributor

phluid61 commented Nov 24, 2017

TODO: write non-Windows unit tests to ensure that these all fail with CURLE_URL_MALFORMAT "File drive letters are only accepted in MSDOS/Windows.":

  • file:c:/
  • file:/c:/
  • file:///c:/
  • file:c|/
  • file:/c|/
  • file:///c|/

@bagder bagder added the URL label Nov 24, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Nov 24, 2017

Member

Thanks!

Member

bagder commented Nov 24, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment