delta: harden external command invocations#21104
Closed
vszakats wants to merge 33 commits into
Closed
Conversation
vszakats
changed the title
There was a problem hiding this comment.
Pull request overview
This PR hardens scripts/delta by reducing shell/pipeline usage and invoking external commands with argument lists to avoid shell interpretation and injection risks.
Changes:
- Introduces a
cmd()helper based onIPC::Open3to run commands without going through the shell. - Replaces several backtick + shell-pipe constructs with Perl-native parsing/counting and safer git invocations.
- Adds
tagstamp()to parse tag timestamps fromgit for-each-refoutput withoutgrep|cut.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This replaced the hang with no output for the previously hanging
example: cmd('git', 'shortlog', '-s'). Other examples with >64KiB output
work OK.
Oddity:
cmd('git', 'shortlog', '-s');
returns 0,
while
cmd('git', 'shortlog', '-s', 'HEAD');
returns the correct result.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
By moving operations Perl-native (from shell and external commands), and passing arguments individually to external commands. Pointed out by Codex Security Closes curl#21104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving operations Perl-native (from shell and external commands), and
passing arguments individually to external commands.
Pointed out by Codex Security
https://github.com/curl/curl/pull/21104/files?w=1
(not an issue in commands using it, but still.)
https://metacpan.org/pod/IPC::Open3