Conversation
Otherwise the trailer state lingers on into subsequent requests. Follow-up to 29610e5 Spotted by Codex Security
bagder
marked this pull request as ready for review
March 27, 2026 08:16
icing
approved these changes
Mar 27, 2026
icing
left a comment
icing
left a comment
Contributor
There was a problem hiding this comment.
I see, a minor nit where a missing trailer on a reset easy that had trailers correctly before would be missed. It's about as likely to happen as me getting pregnant. But a bug nevertheless.
I wonder, given that we have always issues with "resetting" easy/request things, if there is a better way to do this.
Member
Author
Perhaps it could be an idea to have a sub-struct in there that we always memset to zero in new requests. Then they would automatically get reset if we add new members in there... |
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Apr 7, 2026
Otherwise the trailer state lingers on into subsequent requests. Follow-up to 29610e5 Spotted by Codex Security Closes curl#21112
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Otherwise the trailer state lingers on into subsequent requests. Follow-up to 29610e5 Spotted by Codex Security Closes curl#21112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the trailer state lingers on into subsequent requests.
Follow-up to 29610e5
Spotted by Codex Security