libssh: propagate error back in SFTP function#21122
Closed
Conversation
The myssh_in_SFTP_READDIR_BOTTOM() function would not store the error code correctly thus it could be ignored and missed when an error was returned at that particular moment. Follow-up to 3c26e6a Found by Codex Security
bagder
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes libssh SFTP directory listing state machine behavior so write/transfer errors occurring in myssh_in_SFTP_READDIR_BOTTOM() are properly captured and returned to the caller, preventing them from being silently ignored.
Changes:
- Store the
CURLcodeerror intosshc->actualcodewhen theREADDIR_BOTTOMwrite step fails. - Add braces around the error-handling
if(result)block for the updated logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bagder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The myssh_in_SFTP_READDIR_BOTTOM() function would not store the error code correctly thus it could be ignored and missed when an error was returned at that particular moment.
Follow-up to 3c26e6a
Found by Codex Security