Skip to content

build: drop duplicate pthread.h includes#21144

Closed
vszakats wants to merge 1 commit intocurl:masterfrom
vszakats:dupepthreadh
Closed

build: drop duplicate pthread.h includes#21144
vszakats wants to merge 1 commit intocurl:masterfrom
vszakats:dupepthreadh

Conversation

@vszakats
Copy link
Copy Markdown
Member

@vszakats vszakats commented Mar 28, 2026

Already included from curl_setup.h.

@github-actions github-actions bot added the tests label Mar 28, 2026
@vszakats vszakats marked this pull request as draft March 28, 2026 22:42
@vszakats vszakats marked this pull request as ready for review March 28, 2026 23:01
@vszakats vszakats closed this in 930f2e8 Mar 30, 2026
@vszakats vszakats deleted the dupepthreadh branch March 30, 2026 11:47
vszakats added a commit that referenced this pull request Mar 30, 2026
Prior to this patch code used either `HAVE_PTHREAD_H`, or
`HAVE_THREADS_POSIX`, or both, to decide if POSIX Threads support is
present. In effect requiring both to be defined for a consistent build.

Drop detecting and guarding for `pthread.h`, and assume it present when
`HAVE_THREADS_POSIX` is set.

OS/400 had `HAVE_PTHREAD_H` set, but not `HAVE_THREADS_POSIX`, which
possibly left threading disabled in most sources.

Ref: https://pubs.opengroup.org/onlinepubs/009695399/basedefs/pthread.h.html
Ref: 930f2e8 #21144

Closes #21158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant