build: drop duplicate pthread.h includes - #21144
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
vszakats
marked this pull request as draft
March 28, 2026 22:42
vszakats
marked this pull request as ready for review
March 28, 2026 23:01
vszakats
added a commit
that referenced
this pull request
Mar 30, 2026
Prior to this patch code used either `HAVE_PTHREAD_H`, or `HAVE_THREADS_POSIX`, or both, to decide if POSIX Threads support is present. In effect requiring both to be defined for a consistent build. Drop detecting and guarding for `pthread.h`, and assume it present when `HAVE_THREADS_POSIX` is set. OS/400 had `HAVE_PTHREAD_H` set, but not `HAVE_THREADS_POSIX`, which possibly left threading disabled in most sources. Ref: https://pubs.opengroup.org/onlinepubs/009695399/basedefs/pthread.h.html Ref: 930f2e8 #21144 Closes #21158
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Already included from `curl_setup.h`. Closes curl#21144
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Prior to this patch code used either `HAVE_PTHREAD_H`, or `HAVE_THREADS_POSIX`, or both, to decide if POSIX Threads support is present. In effect requiring both to be defined for a consistent build. Drop detecting and guarding for `pthread.h`, and assume it present when `HAVE_THREADS_POSIX` is set. OS/400 had `HAVE_PTHREAD_H` set, but not `HAVE_THREADS_POSIX`, which possibly left threading disabled in most sources. Ref: https://pubs.opengroup.org/onlinepubs/009695399/basedefs/pthread.h.html Ref: 930f2e8 curl#21144 Closes curl#21158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already included from
curl_setup.h.