tool_operate: actually apply the --parallel-max-host limit#21147
Closed
tool_operate: actually apply the --parallel-max-host limit#21147
Conversation
It was wrongly previously only used in debug code for event based transfer and not in the "normal" parallel transfer case. Follow-up to 4654493
icing
approved these changes
Mar 29, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes curl tool parallel mode so the --parallel-max-host setting is actually enforced in the normal (poll/perform) parallel-transfer loop, not only in the debug-only event-based (libuv) path.
Changes:
- Apply
CURLMOPT_MAX_HOST_CONNECTIONSon the multi handle inparallel_transfers(). - Align behavior between the regular parallel codepath and the event-based debug path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was wrongly previously only used in debug code for event based transfer and not in the "normal" parallel transfer case.
Follow-up to 4654493