socks: reject zero-length GSSAPI/SSPI tokens from proxy#21159
Closed
gregkh wants to merge 1 commit intocurl:masterfrom
Closed
socks: reject zero-length GSSAPI/SSPI tokens from proxy#21159gregkh wants to merge 1 commit intocurl:masterfrom
gregkh wants to merge 1 commit intocurl:masterfrom
Conversation
A "broken" SOCKS5 proxy can send an invalid length of the encryption token, which could cause malloc(0) to be called, which is a "platform can do what it wants" potential problem. Resolve this by explicitly checking the length and rejecting the invalid token before ever attempting to allocate any memory.
bagder
approved these changes
Mar 30, 2026
Member
|
augment review |
🤖 Augment PR SummarySummary: Adds explicit validation to reject zero-length GSSAPI/SSPI tokens from SOCKS5 proxies. 🤖 Was this summary useful? React with 👍 or 👎 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A "broken" SOCKS5 proxy can send an invalid length of the encryption token, which could cause malloc(0) to be called, which is a "platform can do what it wants" potential problem.
Resolve this by explicitly checking the length and rejecting the invalid token before ever attempting to allocate any memory.