Skip to content

docs: SSH host verification is done at connect time#21173

Closed
bagder wants to merge 4 commits intomasterfrom
bagder/docs-ssh-conn-reuse
Closed

docs: SSH host verification is done at connect time#21173
bagder wants to merge 4 commits intomasterfrom
bagder/docs-ssh-conn-reuse

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Mar 31, 2026

Connection reuse is done more "casually" once verified.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates libcurl option documentation to clarify that SSH host verification happens when establishing a new connection, and that subsequent connection reuse may occur without re-running the originally configured verification method.

Changes:

  • Document that CURLOPT_SSH_KNOWNHOSTS verification is applied on new connections and that verified connections can later be reused.
  • Document similar “verify on connect, then reuse” behavior for CURLOPT_SSH_HOST_PUBLIC_KEY_SHA256 and CURLOPT_SSH_HOST_PUBLIC_KEY_MD5.
  • Cross-reference the other SSH host verification options in each doc page to set expectations around connection reuse.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
docs/libcurl/opts/CURLOPT_SSH_KNOWNHOSTS.md Adds a note describing verification at connect time and that the connection can later be reused.
docs/libcurl/opts/CURLOPT_SSH_HOST_PUBLIC_KEY_SHA256.md Adds a similar note for SHA256 host key verification and connection reuse behavior.
docs/libcurl/opts/CURLOPT_SSH_HOST_PUBLIC_KEY_MD5.md Adds a similar note for MD5 host key verification and connection reuse behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/libcurl/opts/CURLOPT_SSH_KNOWNHOSTS.md Outdated
Comment thread docs/libcurl/opts/CURLOPT_SSH_HOST_PUBLIC_KEY_SHA256.md Outdated
Comment thread docs/libcurl/opts/CURLOPT_SSH_HOST_PUBLIC_KEY_MD5.md Outdated
Connection reuse is done more "casually" once verified.

Closes #21173
@bagder bagder force-pushed the bagder/docs-ssh-conn-reuse branch from 66d27a4 to 0405b2c Compare March 31, 2026 09:31
@bagder bagder closed this in c31fcf2 Mar 31, 2026
@bagder bagder deleted the bagder/docs-ssh-conn-reuse branch March 31, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants