alt-svc: skip expired entries read from file#21187
Closed
Conversation
Extend test 1654 to verify
There was a problem hiding this comment.
Pull request overview
Updates Alt-Svc cache handling to ignore expired entries when loading from disk, and extends an existing unit test to validate that behavior.
Changes:
- Skip adding Alt-Svc cache entries from file when their parsed expiry timestamp is already in the past.
- Move/enable the debug/unit-test time override earlier in
lib/altsvc.cso the new expiry check uses the deterministicCURL_TIME. - Extend test 1654 input to include an expired entry and adjust other timestamps to ensure the test remains stable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/data/test1654 | Adds an expired Alt-Svc line and updates dates so the output verifies that expired entries are skipped under fixed CURL_TIME. |
| lib/altsvc.c | Skips expired entries during file load (altsvc_add) and ensures time() override is active for debug/unit-test builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend test 1654 to verify