Skip to content

altsvc: drop the prio field from the struct#21188

Closed
bagder wants to merge 1 commit intomasterfrom
bagder/altsvc-drop-prio
Closed

altsvc: drop the prio field from the struct#21188
bagder wants to merge 1 commit intomasterfrom
bagder/altsvc-drop-prio

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Apr 1, 2026

The value is not used for anything, no point in keeping it in memory.

@bagder bagder marked this pull request as ready for review April 1, 2026 07:24
@bagder bagder requested a review from Copilot April 1, 2026 07:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused prio field from the internal Alt-Svc cache entry structure to reduce per-entry memory usage while keeping the on-disk/output format effectively unchanged (still writing a constant 0 priority).

Changes:

  • Dropped unsigned int prio; from struct altsvc.
  • Removed the as->prio initialization and adjusted Alt-Svc cache line output to always emit 0 for priority.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/altsvc.h Removes the unused prio member from struct altsvc.
lib/altsvc.c Stops setting as->prio and hardcodes priority output as 0 when saving entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@testclutch
Copy link
Copy Markdown

Analysis of PR #21188 at 0c981ff7:

Test 3035 failed, but it has been 1.3% flaky lately, so it's probably NOT a fault of the PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Note that this CI job has had a number of other flaky tests recently (2, to be exact) so it may be that this failure is rather a systemic issue with this job and not with this specific PR.

Generated by Testclutch

The value is not used for anything, no point in keeping it in memory.

Closes #21188
@bagder bagder force-pushed the bagder/altsvc-drop-prio branch from 0c981ff to c1963e2 Compare April 1, 2026 09:06
@bagder bagder closed this in c1963e2 Apr 1, 2026
@bagder bagder deleted the bagder/altsvc-drop-prio branch April 1, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants