altsvc: drop the prio field from the struct#21188
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the unused prio field from the internal Alt-Svc cache entry structure to reduce per-entry memory usage while keeping the on-disk/output format effectively unchanged (still writing a constant 0 priority).
Changes:
- Dropped
unsigned int prio;fromstruct altsvc. - Removed the
as->prioinitialization and adjusted Alt-Svc cache line output to always emit0for priority.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/altsvc.h | Removes the unused prio member from struct altsvc. |
| lib/altsvc.c | Stops setting as->prio and hardcodes priority output as 0 when saving entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #21188 at 0c981ff7: Test 3035 failed, but it has been 1.3% flaky lately, so it's probably NOT a fault of the PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Note that this CI job has had a number of other flaky tests recently (2, to be exact) so it may be that this failure is rather a systemic issue with this job and not with this specific PR. Generated by Testclutch |
The value is not used for anything, no point in keeping it in memory. Closes #21188
0c981ff to
c1963e2
Compare
The value is not used for anything, no point in keeping it in memory.