docs: CURLOPT_LOGIN_OPTIONS is a login property#21215
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR clarifies in libcurl documentation that CURLOPT_LOGIN_OPTIONS affects how login is performed when a connection is established, but is not intended to affect connection reuse decisions, and adds a test intended to verify that behavior.
Changes:
- Add
tests/data/test1982to exercise IMAP connection reuse when login options differ between sequential requests. - Register the new test in
tests/data/Makefile.am. - Update
docs/libcurl/opts/CURLOPT_LOGIN_OPTIONS.mdto describeCURLOPT_LOGIN_OPTIONSas a “login property” that should not affect reuse.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/data/test1982 | New IMAP test case intended to validate reuse behavior when login options change. |
| tests/data/Makefile.am | Adds test1982 to the known test list. |
| docs/libcurl/opts/CURLOPT_LOGIN_OPTIONS.md | Documents that login options do not change the connection security context / reuse key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test case 1982 verifies this
bagder
force-pushed
the
bagder/imap-change-options
branch
from
6990ff0 to
ff35e6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case 1982 verifies this