Closed
Conversation
It has already been checked previously in the function. Spotted by CodeSonar
There was a problem hiding this comment.
Pull request overview
This PR simplifies DoH probe completion handling in lib/doh.c by removing a redundant doh_req-presence check that is already enforced earlier in doh_probe_done(), addressing a static analysis report (CodeSonar) without changing behavior.
Changes:
- Remove a superfluous
DEBUGASSERT(doh_req || result)andif(doh_req)guard indoh_probe_done(). - Keep response-body extraction conditional only on
!result, while always removing the probe metadata afterward.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has already been checked previously in the function.
Spotted by CodeSonar