vtls_scache: include cert_blob independently of verifypeer#21222
vtls_scache: include cert_blob independently of verifypeer#21222bagder wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts TLS session cache peer key generation so that a configured client-certificate blob contributes to the cache key regardless of verifypeer being enabled, preventing unintended session reuse across differing client cert inputs.
Changes:
- Moves inclusion of
ssl->cert_blobinto the peer key outside thessl->verifypeerconditional. - Ensures the cert blob hash is always incorporated when present, aligning cache partitioning with actual TLS client-auth configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
icing
left a comment
There was a problem hiding this comment.
Makes sense. Maybe the name cert_blob did not connect in my brain to "client cert" at the time.
The making of the TLS session cache key should use the cert blob independently of verifypeer on/off. Follow-up to fa0ccd9 Spotted by Codex Security
7dd14ff to
0ac312f
Compare
|
augment review |
🤖 Augment PR SummarySummary: Updates TLS session cache peer key generation to always include the client certificate blob, even when peer verification is disabled. 🤖 Was this summary useful? React with 👍 or 👎 |
The making of the TLS session cache key should use the cert blob independently of verifypeer on/off.
Follow-up to fa0ccd9
Spotted by Codex Security