libssh: fix -Wsign-compare in 32-bit builds by dropping a redundant check#21225
libssh: fix -Wsign-compare in 32-bit builds by dropping a redundant check#21225vszakats wants to merge 10 commits intocurl:masterfrom
-Wsign-compare in 32-bit builds by dropping a redundant check#21225Conversation
-Wsign-compare in 32-bit builds"-Wsign-compare in 32-bit builds (correction)
There was a problem hiding this comment.
Pull request overview
Follow-up correction for the libssh SFTP atime/mtime quote handling to avoid -Wsign-compare failures on 32-bit Windows builds, and to ensure CI covers the affected configuration.
Changes:
- Adjusted the
time_tvsUINT_MAXcomparison/capping logic inmyssh_in_SFTP_QUOTE_STAT()to avoid signedness warnings. - Extended Windows CI matrix to include a MinGW32 (i686) cmake+GnuTLS+libssh build to catch 32-bit issues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/vssh/libssh.c | Updates atime/mtime quote timestamp bounds logic to avoid sign-compare on 32-bit builds. |
| .github/workflows/windows.yml | Adds a MinGW32 i686 “gnutls libssh” build to CI matrix for 32-bit coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
-Wsign-compare in 32-bit builds (correction)-Wsign-compare in 32-bit builds by dropping a redundant check
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Follow-up to 8c8eeba #21214 (wrong silencing)
Follow-up to c049c37 #18989 (add redundant check)
Follow-up to c988ec9 #9328 (make check fail)
Follow-up to 44a02d2 #9324 (add original check)