Repository navigation
Conversation
Reported-by: Cutiapreta on hackerone
There was a problem hiding this comment.
Pull request overview
Updates the CURLOPT_SOCKS5_AUTH(3) documentation to clarify how the chosen SOCKS5 authentication method interacts with proxy connection reuse (per the reported issue).
Changes:
- Document that the SOCKS5 authentication method is treated as an access/login-style property and does not alter the security context.
- Clarify that libcurl may reuse proxy connections created with a different SOCKS authentication method when other reuse properties match.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
language Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bagder
marked this pull request as ready for review
April 5, 2026 15:26
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Reported-by: Cutiapreta on hackerone Closes curl#21230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Cutiapreta on hackerone