Skip to content

CURLOPT_SOCKS5_AUTH.md: an access property#21230

Closed
bagder wants to merge 2 commits intomasterfrom
bagder/socks-auth-connect-property
Closed

CURLOPT_SOCKS5_AUTH.md: an access property#21230
bagder wants to merge 2 commits intomasterfrom
bagder/socks-auth-connect-property

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Apr 5, 2026

Reported-by: Cutiapreta on hackerone

Reported-by: Cutiapreta on hackerone
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CURLOPT_SOCKS5_AUTH(3) documentation to clarify how the chosen SOCKS5 authentication method interacts with proxy connection reuse (per the reported issue).

Changes:

  • Document that the SOCKS5 authentication method is treated as an access/login-style property and does not alter the security context.
  • Clarify that libcurl may reuse proxy connections created with a different SOCKS authentication method when other reuse properties match.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/libcurl/opts/CURLOPT_SOCKS5_AUTH.md Outdated
language

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bagder bagder marked this pull request as ready for review April 5, 2026 15:26
@bagder bagder closed this in f3176e0 Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants