protocol: disable connection reuse for SMB(S)#21238
Closed
Conversation
Connections should only be reused when using the same "share" (and perhaps some additional conditions), but instead of fixing this flaw, this change completely disables connection reuse for SMB. This protocol is about to get dropped soon anyway. Reported-by: Osama Hamad
There was a problem hiding this comment.
Pull request overview
Disables connection reuse for SMB/SMBS to avoid incorrect reuse across different SMB shares (given current reuse logic is flawed and SMB is planned for deprecation).
Changes:
- Remove
PROTOPT_CONN_REUSEfrom thesmbscheme definition. - Remove
PROTOPT_CONN_REUSEfrom thesmbsscheme definition (while retainingPROTOPT_SSL).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
use PROTOPT_NONE Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections should only be reused when using the same "share" (and perhaps some additional conditions), but instead of fixing this flaw, this change completely disables connection reuse for SMB. This protocol is about to get dropped soon anyway.
Reported-by: Osama Hamad