configure: tidy up comments#21246
Conversation
|
What's the reason for this? dnl is the accepted way to do comments in m4
and reduces the size of the output files.
|
|
The idea is to use the same comment-style in all files. The patch set first switches The I prefer |
|
personally, I don't think unifying the comments is worth the work. I don't think they cause trouble to anyone |
|
The work is already done, but since I sense we'd prefer staying with |
```
configure:...: gcc -c -Werror-implicit-function-declaration -O2 -Wno-system-headers -D_GNU_SOURCE conftest.c >&5
conftest.c:56:3: error: invalid preprocessing directive #default
56 | # default includes
| ^~~~~~~
configure:...: $? = 1
configure: failed program was:
```
https://github.com/curl/curl/actions/runs/23639833978/job/68857514941?pr=21000
https://github.com/curl/curl/actions/runs/23644221708/job/68872229773?pr=21000 https://github.com/curl/curl/actions/runs/23644221703/job/68872228890?pr=21000 old linux: Get:19 http://archive.debian.org/debian-archive/debian stretch/main amd64 autoconf all 2.69-10 [338 kB] Get:20 http://archive.debian.org/debian-archive/debian stretch/main amd64 autotools-dev all 20161112.1 [73.4 kB] Get:21 http://archive.debian.org/debian-archive/debian stretch/main amd64 automake all 1:1.15-6 [733 kB] ``` checking for nghttp2_session_get_stream_local_window_size in -lnghttp2... no ../configure: line 37874: syntax error near unexpected token `fi' ../configure: line 37874: `fi' ``` due to in ./configure: ``` if eval test \"x\$"$as_ac_Header"\" = x"yes"; then : cat >>confdefs.h <<_ACEOF _ACEOF # to do if not found else # to do if found fi ``` later versions solve this by using `case`.
# comments (from dnl)
#comments todnl, except copyright headers, and inlinecomments in
curl-complilers.m4.dnlmarkers. (exceptzz40-xc-ovr.m4where it'sused to produce a comment in
configure.)dnlline with C comment inAC_CHECK_HEADERS().Verified to produce the same
configurescript except empty lines,#comments, and C comments, with autoreconf 2.72.Cherry-picked from #21000
dnl→#changes.