Skip to content

curl_ntlm_core: use wolfCrypt DES API with wolfSSL#21247

Closed
vszakats wants to merge 13 commits intocurl:masterfrom
vszakats:dessimpl
Closed

curl_ntlm_core: use wolfCrypt DES API with wolfSSL#21247
vszakats wants to merge 13 commits intocurl:masterfrom
vszakats:dessimpl

Conversation

@vszakats
Copy link
Copy Markdown
Member

@vszakats vszakats commented Apr 7, 2026

Replacing the last uses of the OpenSSL compatibility API, and dropping
the redefinition of external symbols.

@vszakats vszakats marked this pull request as draft April 7, 2026 00:58
@vszakats vszakats marked this pull request as ready for review April 7, 2026 01:19
@vszakats vszakats changed the title wolfssl: use native DES crypto API curl_ntlm_auth: use wolfCrypt DES API with wolfSSL Apr 7, 2026
@vszakats vszakats changed the title curl_ntlm_auth: use wolfCrypt DES API with wolfSSL curl_ntlm_core: use wolfCrypt DES API with wolfSSL Apr 7, 2026
@bagder bagder requested a review from Copilot April 7, 2026 05:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates curl’s NTLM core DES support for the wolfSSL backend to use wolfCrypt’s DES API, removing the remaining reliance on wolfSSL’s OpenSSL-compatibility DES layer.

Changes:

  • Switch curl_ntlm_core wolfSSL DES implementation to wolfCrypt (wc_Des_SetKey / wc_Des_EcbEncrypt).
  • Update Autotools and CMake feature detection/macros from HAVE_WOLFSSL_DES_ECB_ENCRYPT to HAVE_WC_DES_ECBENCRYPT.
  • Refresh CMake install documentation to reflect the new capability macro.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
m4/curl-wolfssl.m4 Autotools: detect wc_Des_EcbEncrypt and expose it for NTLM-core enablement.
lib/curl_setup.h Gate USE_CURL_NTLM_CORE on HAVE_WC_DES_ECBENCRYPT for wolfSSL builds.
lib/curl_ntlm_core.c Replace wolfSSL OpenSSL-compat DES usage with wolfCrypt DES primitives.
lib/curl_config-cmake.h.in CMake config header template: replace old wolfSSL DES macro with new wolfCrypt one.
docs/INSTALL-CMAKE.md Document the new HAVE_WC_DES_ECBENCRYPT CMake variable.
configure.ac Autotools: enable NTLM core when HAVE_WC_DES_ECBENCRYPT is present.
CMakeLists.txt CMake: detect wc_Des_EcbEncrypt and use it for NTLM-core enablement logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vszakats vszakats closed this in a0d5d8f Apr 7, 2026
@vszakats vszakats deleted the dessimpl branch April 7, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants