curl_ntlm_core: use wolfCrypt DES API with wolfSSL#21247
Closed
vszakats wants to merge 13 commits intocurl:masterfrom
Closed
curl_ntlm_core: use wolfCrypt DES API with wolfSSL#21247vszakats wants to merge 13 commits intocurl:masterfrom
vszakats wants to merge 13 commits intocurl:masterfrom
Conversation
bagder
approved these changes
Apr 7, 2026
There was a problem hiding this comment.
Pull request overview
Updates curl’s NTLM core DES support for the wolfSSL backend to use wolfCrypt’s DES API, removing the remaining reliance on wolfSSL’s OpenSSL-compatibility DES layer.
Changes:
- Switch
curl_ntlm_corewolfSSL DES implementation to wolfCrypt (wc_Des_SetKey/wc_Des_EcbEncrypt). - Update Autotools and CMake feature detection/macros from
HAVE_WOLFSSL_DES_ECB_ENCRYPTtoHAVE_WC_DES_ECBENCRYPT. - Refresh CMake install documentation to reflect the new capability macro.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| m4/curl-wolfssl.m4 | Autotools: detect wc_Des_EcbEncrypt and expose it for NTLM-core enablement. |
| lib/curl_setup.h | Gate USE_CURL_NTLM_CORE on HAVE_WC_DES_ECBENCRYPT for wolfSSL builds. |
| lib/curl_ntlm_core.c | Replace wolfSSL OpenSSL-compat DES usage with wolfCrypt DES primitives. |
| lib/curl_config-cmake.h.in | CMake config header template: replace old wolfSSL DES macro with new wolfCrypt one. |
| docs/INSTALL-CMAKE.md | Document the new HAVE_WC_DES_ECBENCRYPT CMake variable. |
| configure.ac | Autotools: enable NTLM core when HAVE_WC_DES_ECBENCRYPT is present. |
| CMakeLists.txt | CMake: detect wc_Des_EcbEncrypt and use it for NTLM-core enablement logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the last uses of the OpenSSL compatibility API, and dropping
the redefinition of external symbols.