HTTPS-RR use in HTTP/3#21253
Closed
icing wants to merge 2 commits into
Closed
Conversation
When HTTPS-RR is needed for the HTTP/3 handshake, delay the connect until it arrives. Relevant only for TLS backends that support ECH, for now.
bagder
approved these changes
Apr 7, 2026
There was a problem hiding this comment.
Pull request overview
This PR ensures that when ECH requires HTTPS RR information for the HTTP/3 (QUIC) handshake, the QUIC connect is delayed until the HTTPS RR result is available (or resolution completes), avoiding premature handshake attempts.
Changes:
- Exposes TLS-backend helpers (
Curl_ossl_need_httpsrr,Curl_wssl_need_httpsrr) to indicate when HTTPS RR is required for ECH. - Adds “delay connect until HTTPS RR is resolved” logic to HTTP/3 connect paths (ngtcp2 and quiche).
- Adjusts ECH-related log messages to refer generically to “HTTPS RR”.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/vtls/wolfssl.h | Declares Curl_wssl_need_httpsrr() for cross-module use. |
| lib/vtls/wolfssl.c | Implements Curl_wssl_need_httpsrr() and uses it to delay TLS connect until HTTPS RR is known; updates ECH log text. |
| lib/vtls/openssl.h | Declares Curl_ossl_need_httpsrr() for cross-module use. |
| lib/vtls/openssl.c | Implements Curl_ossl_need_httpsrr() (with stub when unsupported), uses it to delay TLS connect until HTTPS RR is known; updates ECH log text. |
| lib/vquic/curl_quiche.c | Delays QUIC connect when OpenSSL/BoringSSL ECH needs HTTPS RR and it’s not resolved yet. |
| lib/vquic/curl_ngtcp2.c | Adds backend-aware helper to decide if HTTPS RR is needed and delays QUIC connect until HTTPS RR is resolved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When HTTPS-RR is needed for the HTTP/3 handshake, delay the connect until it arrives. Relevant only for TLS backends that support ECH, for now.