Repository navigation
Conversation
vszakats
changed the title
vszakats
marked this pull request as draft
April 8, 2026 01:21
vszakats
changed the title
vszakats
marked this pull request as ready for review
April 8, 2026 01:37
There was a problem hiding this comment.
Pull request overview
Aligns the Autotools configure warning flags with existing CMake behavior by suppressing clang warnings that are noisy/pointless when building in C89/C90 mode, and adds CI coverage for an Intel clang C89 build.
Changes:
- Autotools: when clang is used with
-std=gnu89/gnu90/c89/c90, add suppressions for-Wc99-extensionsand-Wcomma. - CI (Linux): add an “openssl intel C89 clang” job to exercise the C89+clang configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
m4/curl-compilers.m4 |
Adds clang C89/C90-specific warning suppressions to match CMake’s behavior. |
.github/workflows/linux.yml |
Adds a new Linux CI matrix entry to run an Intel clang C89 build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Syncing with CMake. Follow-up to 43397b0 curl#21015 Follow-up to 09c9afd curl#20363 Closes curl#21263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing with CMake.
Follow-up to 43397b0 #21015
Follow-up to 09c9afd #20363
Tested OK in CI: https://github.com/curl/curl/actions/runs/24113060450/job/70351552661?pr=21263