lib: revise exporting of symbols #2127

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

wmark commented Nov 29, 2017

Static-Linking dependencies to curl I noticed that curl re-exports those other symbols, which is unexpected.

@bagder bagder added the build label Nov 30, 2017

lib: don't export all symbols, just everything curl_*
Absent any 'symbol map' or script to limit what gets exported, static
linking of libraries previously resulted in a libcurl with curl's and
those other symbols being (re-)exported.

This did not happen if 'versioned symbols' were enabled (which is not
the default) because then a version script is employed.

This limits exports to everything starting in 'curl_*'., which is
what "libcurl.vers" exports.

This avoids strange side-effects such as with mixing methods
from system libraries and those erroneously offered by libcurl.
Contributor

wmark commented Nov 30, 2017

Rebased, improved the commit message. Code didn't change. This is the only and last commit in this PR.

Owner

bagder commented Dec 1, 2017

Thanks!

@bagder bagder closed this in 4b41424 Dec 1, 2017

@wmark wmark deleted the wmark:export-control branch Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment