/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: revise exporting of symbols #2127

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@bagder bagder

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@wmark @bagder
@wmark
Contributor

wmark commented Nov 29, 2017 •
edited

Static-Linking dependencies to curl I noticed that curl re-exports those other symbols, which is unexpected.

@bagder bagder added the build label Nov 30, 2017

@bagder

bagder approved these changes Nov 30, 2017
View changes

@wmark
lib: don't export all symbols, just everything curl_* 
Absent any 'symbol map' or script to limit what gets exported, static
linking of libraries previously resulted in a libcurl with curl's and
those other symbols being (re-)exported.

This did not happen if 'versioned symbols' were enabled (which is not
the default) because then a version script is employed.

This limits exports to everything starting in 'curl_*'., which is
what "libcurl.vers" exports.

This avoids strange side-effects such as with mixing methods
from system libraries and those erroneously offered by libcurl.
Verified
This commit was signed with a verified signature.
@wmark wmark Mark Kubacki
GPG key ID: 6EEA1B079F620003 Learn about signing commits
Loading status checks…
bf9df95
@wmark

This comment has been minimized.

Sign in to view
Contributor

wmark commented Nov 30, 2017

Rebased, improved the commit message. Code didn't change. This is the only and last commit in this PR.
@bagder

This comment has been minimized.

Sign in to view
Member

bagder commented Dec 1, 2017

Thanks!

@bagder bagder closed this in 4b41424 Dec 1, 2017

@wmark wmark deleted the wmark:export-control branch Dec 1, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.