setopt: move CURLOPT_CURLU#21298
Closed
bagder wants to merge 1 commit into
Closed
Conversation
To fix cast from 'char *' to 'CURLU *' (aka 'struct Curl_URL *') increases required alignment from 1 to 8 Follow-up to 3407bee
There was a problem hiding this comment.
Pull request overview
This PR adjusts how CURLOPT_CURLU is routed and parsed inside Curl_vsetopt() so the option is read from the variadic argument list as a CURLU * (instead of as a char *), eliminating the problematic cast/alignment/UB scenario and keeping CURLOPT_CURLU consistent with other non-string pointer options.
Changes:
- Move
CURLOPT_CURLUhandling fromsetopt_cptr()tosetopt_pointers(). - Update
Curl_vsetopt()dispatch soCURLOPT_CURLUis handled viasetopt_pointers()and read withva_arg(param, CURLU *). - Remove the old
(CURLU *)ptrcast path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Apr 13, 2026
To fix cast from 'char *' to 'CURLU *' (aka 'struct Curl_URL *') increases required alignment from 1 to 8 Follow-up to 3407bee Closes curl#21298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix cast from 'char *' to 'CURLU *' (aka 'struct Curl_URL *') increases required alignment from 1 to 8
Follow-up to 3407bee