http: use header_has_value() instead of duplicate code#21302
Closed
bagder wants to merge 4 commits into
Closed
Conversation
bagder
force-pushed
the
bagder/has-value
branch
from
fb7c8d8 to
aac5190
Compare
There was a problem hiding this comment.
Pull request overview
Refactors HTTP header parsing in lib/http.c to avoid duplicated logic by introducing a shared helper.
Changes:
- Added
header_has_value()helper to centralize header-name/value parsing and trimming. - Updated
http_header_is_empty()andcopy_custom_value()to use the new helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
language Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
indent Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.