http: clear digest nonce on cross-orgin redirect#21359
Closed
bagder wants to merge 5 commits into
Closed
Conversation
Verify in test 1966 Reported-by: Yalguun Tumenkhuu
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent HTTP Digest authentication state (nonce/challenge) from being reused across cross-origin redirects, and adds a regression test to verify the expected behavior.
Changes:
- Add test1966 covering digest auth with netrc credentials and redirect to a different origin.
- Register the new test in the tests/data Makefile.
- Update redirect-follow logic to clear Digest nonce when redirecting to a different origin.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/data/test1966 | New regression test for digest auth + cross-origin redirect behavior |
| tests/data/Makefile.am | Adds test1966 to the test suite list |
| lib/http.c | Clears Digest state on cross-origin redirect during Curl_http_follow() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
better cleanup Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify in test 1966
Reported-by: Yalguun Tumenkhuu