misc: fix code quality findings

[vszakats]

• httpsrr: drop redundant checks.
  Follow-up to 809dda3 Happy Eyeballs, resolution time delay #21354
• httpsrr.h: drop obsolete comment.
  Follow-up to 2b3dfb4 Make resolving HTTPS DNS records reliable: #21175
• ws: drop redundant check in curl_ws_start_frame().
  Follow-up to 37cecfc websocket: support CURLOPT_READFUNCTION #17683
• ws: fix typo in comment.
• tool_operate: fix VMS build. (broken since 2019-07-20, v7.66.0)
  Follow-up to b889408 curl: support parallel transfers #3804

Pointed out by Copilot Code Quality

[Copilot]

Pull request overview

This PR addresses static/code quality findings across the tool and lib layers, primarily by removing redundant checks/comments, correcting a typo, and fixing VMS-specific build breakage in the curl tool.

Changes:

• Fix VMS build issues in tool_operate by using the correct per-transfer fields when calling VMS helpers / opening output files.
• Simplify HTTPS-RR applicability logic and remove an obsolete struct comment.
• WebSocket cleanup: remove a redundant raw-mode check in curl_ws_start_frame() and fix a typo in a comment.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/tool_operate.c	Fixes VMS-specific references to use per->uploadfile / per->outfile, restoring build correctness.
lib/ws.c	Cleans up redundant checking in curl_ws_start_frame() and fixes a comment typo.
lib/httpsrr.h	Removes an obsolete/incorrect comment about port.
lib/httpsrr.c	Removes redundant conditions in Curl_httpsrr_applicable() for clarity.

Comments suppressed due to low confidence (1)

lib/ws.c:1885

• curl_ws_start_frame() is a public API, and this change alters the observable error contract in raw mode (previously CURLE_SEND_ERROR with a [WS] ... message; now CURLE_FAILED_INIT with a different message and it also skips the usual [WS] prefix used throughout this file). To avoid breaking callers that check specific CURLcode values / messages, consider keeping the previous CURLcode and error text (or document the new error code in the manpage and align the message prefixing with other WS errors).

  if(data->set.ws_raw_mode) {
    failf(data, "cannot curl_ws_start_frame() with CURLWS_RAW_MODE enabled");
    return CURLE_FAILED_INIT;
  }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.