setup connection filter: mark as setup#21437
Closed
icing wants to merge 3 commits into
Closed
Conversation
Add CF_TYPE_SETUP to the setup connection filter so that it is removed and destroyed after the connection has been established.
Add indicator for filters that are not connected.
bagder
approved these changes
Apr 24, 2026
There was a problem hiding this comment.
Pull request overview
This PR ensures the connection “SETUP” filter is correctly treated as setup-only so it gets removed after a connection is established, and it adds verbose tracing to show the connection filter chain before and after setup filters are discarded.
Changes:
- Mark
Curl_cft_setupwithCF_TYPE_SETUPso it is removed/destroyed post-connect. - Add verbose tracing of the connection filter chain on connect success/failure.
- Trace the “reduced” chain after setup filters have been removed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/connect.c | Marks the SETUP connection filter type with CF_TYPE_SETUP so it is eligible for post-connect removal. |
| lib/cfilters.c | Adds verbose-only filter-chain tracing and emits traces on connect success/failure and after setup-filter removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Apr 27, 2026
Add CF_TYPE_SETUP to the setup connection filter so that it is removed and destroyed after the connection has been established. Closes curl#21437
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CF_TYPE_SETUP to the setup connection filter so that it is removed and destroyed after the connection has been established.
As an extra: add tracing of the filter chain when connect attempt succeeded or failed. Which then shows something like: