mbedtls: cleanup more without care for 'initialized'#21440
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Several mbedTLS resources (entropy/CTR-DRBG, CA/client certs, keys, CRL) are initialized and may allocate memory before initialized is set, and must still be cleaned up. Follow-up to 1c4813c Caught by Codex Security
There was a problem hiding this comment.
Pull request overview
Ensures mbedTLS-related resources are cleaned up even when backend->initialized was never set, preventing leaks on early failures during TLS setup.
Changes:
- Always free client/CA certs, private key, CRL (when enabled), configured ciphersuites, and
mbedtls_ssl_configinmbedtls_close() - Keep
mbedtls_ssl_free(&backend->ssl)guarded bybackend->initialized
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several mbedTLS resources (entropy/CTR-DRBG, CA/client certs, keys, CRL) are initialized and may allocate memory before initialized is set, and must still be cleaned up.
Follow-up to 1c4813c
Caught by Codex Security