Skip to content

mbedtls: remove failf() call with first argument as NULL#21441

Closed
bagder wants to merge 1 commit into
masterfrom
bagder/mbedtls-failf
Closed

mbedtls: remove failf() call with first argument as NULL#21441
bagder wants to merge 1 commit into
masterfrom
bagder/mbedtls-failf

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Apr 24, 2026

failf() needs an easy handle to work. This change removes the call since there is normnally nowhere to show the output if init fails.

Bonus: improve language in an infof() call

Spotted by Copilot

failf() needs an easy handle to work. This change removes the call since
there is normnally nowhere to show the output if init fails.

Bonus: improve language in an infof() call

Spotted by Copilot
@github-actions github-actions Bot added the TLS label Apr 24, 2026
@bagder bagder marked this pull request as ready for review April 24, 2026 15:29
@bagder
Copy link
Copy Markdown
Member Author

bagder commented Apr 24, 2026

augment review

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 24, 2026

🤖 Augment PR Summary

Summary: Updates the mbedTLS backend to avoid calling failf() without a valid easy handle during global init.
Changes: Tweaks the certinfo limit message wording and removes the failf(NULL, ...) on mbedtls_ctr_drbg_seed() failure, keeping the existing “return 0” failure path.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@bagder bagder closed this in 7d29514 Apr 24, 2026
@bagder bagder deleted the bagder/mbedtls-failf branch April 24, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant