cmake: auto-select static nghttp2/nghttp3/ngtcp2 Config#21470
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
When detecting these dependencies via CMake Config and their main imported target is undefined, automatically assume and use their static imported targets instead. Adopting from vcpkg downstream, doing it for nghttp3 and ngtcp2, but not for nghttp2. Refs: https://github.com/microsoft/vcpkg/blob/773e092a82fc3b4c3e73ee7b049a5e119fa45898/ports/curl/dependencies.patch microsoft/vcpkg@70b941a Original-patch-by: Kai Pastor
vszakats
added
the
feature-window
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
When detecting these dependencies via CMake Config and their main imported target is undefined, automatically assume and use their static imported target instead. Adopting from vcpkg downstream, where it's done for nghttp3 and ngtcp2, but not for nghttp2. Refs: https://github.com/microsoft/vcpkg/blob/773e092a82fc3b4c3e73ee7b049a5e119fa45898/ports/curl/dependencies.patch microsoft/vcpkg@70b941a Downstream-patch-by: Kai Pastor Closes curl#21470
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When detecting these dependencies via CMake Config and their main
imported target is undefined, automatically assume and use their static
imported target instead.
Adopting from vcpkg downstream, where it's done for nghttp3 and ngtcp2,
but not for nghttp2.
Refs:
https://github.com/microsoft/vcpkg/blob/773e092a82fc3b4c3e73ee7b049a5e119fa45898/ports/curl/dependencies.patch
microsoft/vcpkg@70b941a
Downstream-patch-by: Kai Pastor
Is it useful in context of curl in general?
Upside is making builds work by default in more cases, downside is silently changing
build configuration depending on how these dependencies were built. This is limited
to builds using Config, which came with 8.20.0, released today.