setopt: changing the proxy port is also a proxy change#21485
Closed
bagder wants to merge 3 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates libcurl's proxy option handling so changing CURLOPT_PROXYPORT is treated like changing the proxy itself, resetting cached proxy authentication state in lib/setopt.c. It fits into the setopt path that prepares per-handle proxy configuration and auth state before transfers.
Changes:
- Introduces a shared
changeproxy()helper to clear cached proxy Digest/auth state. - Calls that helper when
CURLOPT_PROXYPORTchanges, not just when the proxy string changes. - Refactors the proxy-specific
setopt_long_proxy()preprocessor layout slightly while keeping the no-proxy-disabled stub.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.