lib: drop support for CURLAUTH_DIGEST_IE#21486
Merged
Merged
Conversation
bagder
added a commit
that referenced
this pull request
May 11, 2026
This bit was used to do Digest authentication like Internet Explorer before version 7 (released on October 18, 2006). Presumably no one uses this anymore and since it is hard to use and does broken auth, starting in 8.21.0 this bit does nothing (except setting the actual Digest bit). Closes #21486
043090d to
7f9ccf6
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy “IE-style” HTTP Digest authentication behavior (pre-IE7 URI handling) from libcurl internals, keeping CURLAUTH_DIGEST_IE only as a compatibility bit that maps to standard Digest.
Changes:
- Removes the internal
auth.iestylestate and the associated IE-style Digest URI truncation logic. - Simplifies
CURLOPT_HTTPAUTHhandling to treatCURLAUTH_DIGEST_IEas standard Digest. - Updates the
CURLOPT_HTTPAUTHdocumentation to indicateCURLAUTH_DIGEST_IEno longer provides IE-specific behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/urldata.h | Drops struct auth’s iestyle bit. |
| lib/setopt.c | Removes setting of the iestyle marker and maps CURLAUTH_DIGEST_IE toward standard Digest. |
| lib/http_digest.c | Removes IE-style Digest URI handling and always uses the full uripath. |
| docs/libcurl/opts/CURLOPT_HTTPAUTH.md | Updates documentation text and history for CURLAUTH_DIGEST_IE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This bit was used to do Digest authentication like Internet Explorer before version 7 (released on October 18, 2006). Presumably no one uses this anymore and since it is hard to use and does broken auth, starting in 8.21.0 this bit does nothing (except setting the actual Digest bit). Closes #21486
b3470a7 to
37b2403
Compare
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
This bit was used to do Digest authentication like Internet Explorer before version 7 (released on October 18, 2006). Presumably no one uses this anymore and since it is hard to use and does broken auth, starting in 8.21.0 this bit does nothing (except setting the actual Digest bit). Closes curl#21486
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bit was used to do Digest authentication like Internet Explorer before version 7 (released on October 18, 2006). Presumably no one uses this anymore and since it is hard to use and does broken auth, starting in 8.21.0 this bit does nothing (except setting the actual Digest bit).