Skip to content

lib: drop support for CURLAUTH_DIGEST_IE#21486

Merged
bagder merged 1 commit into
masterfrom
bagder/drop-digest-ie
May 11, 2026
Merged

lib: drop support for CURLAUTH_DIGEST_IE#21486
bagder merged 1 commit into
masterfrom
bagder/drop-digest-ie

Conversation

@bagder

@bagder bagder commented May 2, 2026

Copy link
Copy Markdown
Member

This bit was used to do Digest authentication like Internet Explorer before version 7 (released on October 18, 2006). Presumably no one uses this anymore and since it is hard to use and does broken auth, starting in 8.21.0 this bit does nothing (except setting the actual Digest bit).

@bagder bagder added authentication feature-window A merge of this requires an open feature window HTTP labels May 2, 2026
@bagder bagder marked this pull request as ready for review May 2, 2026 20:54
@bagder bagder requested a review from Copilot May 11, 2026 11:30
bagder added a commit that referenced this pull request May 11, 2026
This bit was used to do Digest authentication like Internet Explorer
before version 7 (released on October 18, 2006). Presumably no one uses
this anymore and since it is hard to use and does broken auth, starting
in 8.21.0 this bit does nothing (except setting the actual Digest bit).

Closes #21486
@bagder bagder force-pushed the bagder/drop-digest-ie branch from 043090d to 7f9ccf6 Compare May 11, 2026 11:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy “IE-style” HTTP Digest authentication behavior (pre-IE7 URI handling) from libcurl internals, keeping CURLAUTH_DIGEST_IE only as a compatibility bit that maps to standard Digest.

Changes:

  • Removes the internal auth.iestyle state and the associated IE-style Digest URI truncation logic.
  • Simplifies CURLOPT_HTTPAUTH handling to treat CURLAUTH_DIGEST_IE as standard Digest.
  • Updates the CURLOPT_HTTPAUTH documentation to indicate CURLAUTH_DIGEST_IE no longer provides IE-specific behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File Description
lib/urldata.h Drops struct auth’s iestyle bit.
lib/setopt.c Removes setting of the iestyle marker and maps CURLAUTH_DIGEST_IE toward standard Digest.
lib/http_digest.c Removes IE-style Digest URI handling and always uses the full uripath.
docs/libcurl/opts/CURLOPT_HTTPAUTH.md Updates documentation text and history for CURLAUTH_DIGEST_IE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/setopt.c Outdated
Comment thread docs/libcurl/opts/CURLOPT_HTTPAUTH.md Outdated
This bit was used to do Digest authentication like Internet Explorer
before version 7 (released on October 18, 2006). Presumably no one uses
this anymore and since it is hard to use and does broken auth, starting
in 8.21.0 this bit does nothing (except setting the actual Digest bit).

Closes #21486
@bagder bagder force-pushed the bagder/drop-digest-ie branch from b3470a7 to 37b2403 Compare May 11, 2026 11:43
@bagder bagder closed this in 37b2403 May 11, 2026
@bagder bagder merged commit 37b2403 into master May 11, 2026
214 of 215 checks passed
@bagder bagder deleted the bagder/drop-digest-ie branch May 11, 2026 12:43
outcast36 pushed a commit to greearb/curl that referenced this pull request Jun 3, 2026
This bit was used to do Digest authentication like Internet Explorer
before version 7 (released on October 18, 2006). Presumably no one uses
this anymore and since it is hard to use and does broken auth, starting
in 8.21.0 this bit does nothing (except setting the actual Digest bit).

Closes curl#21486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication feature-window A merge of this requires an open feature window HTTP

Development

Successfully merging this pull request may close these issues.

2 participants