tool_formparse: polish error message + make two functions static#21510
Closed
bagder wants to merge 2 commits into
Closed
tool_formparse: polish error message + make two functions static#21510bagder wants to merge 2 commits into
bagder wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the encapsulation of curl tool form parsing internals by making stdin mime callbacks file-local and improves the clarity of the related stdin read error message.
Changes:
- Make
tool_mime_stdin_read()andtool_mime_stdin_seek()staticintool_formparse.c. - Remove the corresponding declarations from
tool_formparse.hsince they are no longer part of the header’s API surface. - Update the stdin read failure warning message to be more explicit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tool_formparse.h | Removes now-internal callback declarations from the public header surface. |
| src/tool_formparse.c | Makes stdin callbacks static and updates the warning message; removes unnecessary callback casts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.