url: remove ssh_config_matches#21519
Closed
bagder wants to merge 1 commit into
Closed
Conversation
The CURLOPT_SSH_HOST_PUBLIC_KEY_* options are documented to verify the host at connect time and not for connection reuse. Once the SSH host has been deemed okay, it remains okay as long as the connection survives. In addition: this function currently always returned TRUE since the pointers have been NULLed in the SSH backend code before this function is called. Follow-up to c31fcf2 Reported-by: Andrew Nesbit
There was a problem hiding this comment.
Pull request overview
This PR removes SSH-specific connection-cache matching logic that was effectively redundant for SCP/SFTP: SSH host verification options are documented to apply only when establishing a new connection, and the removed helper compared fields that are cleared by the SSH backends before reuse matching occurs.
Changes:
- Remove the
ssh_config_matches()helper fromlib/url.c. - Stop applying SSH-specific “proto config” reuse checks in
url_match_proto_config().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #21519 at 91df8936: Test 3210 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 12 different CI jobs (the link just goes to one of them). Generated by Testclutch |
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
The CURLOPT_SSH_HOST_PUBLIC_KEY_* options are documented to verify the host at connect time and not for connection reuse. Once the SSH host has been deemed okay, it remains okay as long as the connection survives. In addition: this function currently always returned TRUE since the pointers have been NULLed in the SSH backend code before this function is called. Follow-up to c31fcf2 Reported-by: Andrew Nesbit Closes curl#21519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CURLOPT_SSH_HOST_PUBLIC_KEY_* options are documented to verify the host at connect time and not for connection reuse. Once the SSH host has been deemed okay, it remains okay as long as the connection survives.
In addition: this function currently always returned TRUE since the pointers have been NULLed in the SSH backend code before this function is called.
Follow-up to c31fcf2
Reported-by: Andrew Nesbit