Skip to content

Fix zstd CMake config name#21538

Closed
dg0yt wants to merge 1 commit into
curl:masterfrom
dg0yt:zstd
Closed

Fix zstd CMake config name#21538
dg0yt wants to merge 1 commit into
curl:masterfrom
dg0yt:zstd

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented May 8, 2026

They install zstdConfig.cmake, https://github.com/facebook/zstd/blob/885c79ba4ae8345e006f61bc97b270d4cf7ff076/build/cmake/CMakeModules/ZstdPackage.cmake#L33-L38.
With the Config.cmake pattern, this is a case-sensitive package name, zstd.

Congrats. This Find module now has zstd, Zstd and ZSTD vars.

@vszakats vszakats closed this in 10d4b34 May 11, 2026
@vszakats
Copy link
Copy Markdown
Member

Thanks!

@dg0yt dg0yt deleted the zstd branch May 12, 2026 03:42
outcast36 pushed a commit to greearb/curl that referenced this pull request Jun 3, 2026
They install `zstdConfig.cmake`,
https://github.com/facebook/zstd/blob/885c79ba4ae8345e006f61bc97b270d4cf7ff076/build/cmake/CMakeModules/ZstdPackage.cmake#L33-L38.
With the `Config.cmake` pattern, this is a case-sensitive package name,
`zstd`.

Follow-up to 8fce3e1 curl#20814
Closes curl#21538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants