ftp: avoid accessing EPSV response one byte past the NULL#21545
Closed
bagder wants to merge 1 commit into
Closed
Conversation
If the response is just a single "(".
Reported-by: Andrew Nesbit
There was a problem hiding this comment.
Pull request overview
This PR hardens FTP EPSV (229) response parsing in lib/ftp.c to avoid reading one byte past the terminating NUL when the server reply contains only a single "(" with no delimiter/port payload.
Changes:
- Add a guard (
sepmust be non-NUL) before accessingptr[1],ptr[2], andptr[3]in the EPSV reply parser.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
If the response is just a single "(".
Reported-by: Andrew Nesbit
Closes curl#21545
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the response is just a single "(".
Reported-by: Andrew Nesbit