tftp: stricter option name checks#21560
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Previously, the use of checkprefix() alone allowed the code to match not only on "blksize" but also (mistakenly) on "blksizeFOO" etc. Reported-by: Andrew Nesbit
There was a problem hiding this comment.
Pull request overview
Tightens TFTP OACK option parsing in lib/tftp.c so option names must match exactly (not just by prefix), preventing unintended matches like "blksizeFOO" being treated as "blksize".
Changes:
- Compute the received option name length once per loop iteration.
- Require an exact-length match in addition to
checkprefix()forblksize. - Require an exact-length match in addition to
checkprefix()fortsize.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #21560 at 56aea468: Test 2410 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 10 different CI jobs (the link just goes to one of them). Note that this CI job has had a number of other flaky tests recently (2, to be exact) so it may be that this failure is rather a systemic issue with this job and not with this specific PR. Generated by Testclutch |
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Previously, the use of checkprefix() alone allowed the code to match not only on "blksize" but also (mistakenly) on "blksizeFOO" etc. Reported-by: Andrew Nesbit Closes curl#21560
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the use of checkprefix() alone allowed the code to match not only on "blksize" but also (mistakenly) on "blksizeFOO" etc.
Reported-by: Andrew Nesbit