tool_urlglob: make globbing error reported for correct position#21561
Closed
bagder wants to merge 1 commit into
Closed
tool_urlglob: make globbing error reported for correct position#21561bagder wants to merge 1 commit into
bagder wants to merge 1 commit into
Conversation
Reported by Codex Security
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the curl tool’s URL globbing parser tracks and reports error positions, so diagnostics point at the correct location in the input URL (per the reported issue).
Changes:
- Report “unmatched brace” errors using the current parsing position instead of the opening-brace position.
- When parsing a named glob (
{<name>...}/[<name>...]), advance the trackedposby the number of characters consumed by the name syntax so downstream error locations align with the real input offset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Reported by Codex Security Closes curl#21561
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by Codex Security