url_match_destination fix#21573
Closed
icing wants to merge 2 commits into
Closed
Conversation
bagder
approved these changes
May 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR adjusts connection reuse matching in url_match_destination() to also require origin/via_peer destination equality for non-SSL schemes.
Changes:
- Moves the
origin/via_peerdestination comparison so it runs unconditionally (instead of only under the TLS / non-proxy / tunnel-proxy conditional).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Match origin/via_peer also for non-SSL schemes.
Add test case for connection reuse against http: proxy (no tunnel) Fix `url_match_destination()` by - handling http: proxy case explicitly - handling scheme differences irregardless of TLS flag in needle - evaluating `url_match_ssl_use()` on scheme differences (was a separate call in the "match chain" before) - only comparing hostname/port of origin otherwise
icing
force-pushed
the
url_match_destination_fix
branch
from
c62bf3b to
fc9d96b
Compare
Contributor
Author
|
Reworked the logic after adding a test case for http: proxy connection reuse. Knew there was something amiss yesterday. |
bagder
approved these changes
May 15, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Match origin/via_peer also for non-SSL schemes. Closes curl#21573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match origin/via_peer also for non-SSL schemes.