ldap: fix to not leak attribute on OOM (WinLDAP)#21576
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
Reported-by: Andrew Nesbitt
bagder
approved these changes
May 12, 2026
There was a problem hiding this comment.
Pull request overview
Fixes a Windows (WinLDAP) out-of-memory cleanup path in the LDAP transfer implementation to avoid leaking the attribute buffer when curlx_convert_tchar_to_UTF8() fails.
Changes:
- Free
attributewithldap_memfree()before bailing out on UTF-8 conversion OOM in the WinLDAP attribute loop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vszakats
changed the title
attribute on OOM (Windows)attribute on OOM (WinLDAP)
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Reported-by: Andrew Nesbitt Closes curl#21576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Andrew Nesbitt