CURLOPT_MAXFILESIZE: clarify this also works for on-going transfers#21582
Closed
bagder wants to merge 3 commits into
Closed
CURLOPT_MAXFILESIZE: clarify this also works for on-going transfers#21582bagder wants to merge 3 commits into
bagder wants to merge 3 commits into
Conversation
It was not really clear, but it has worked like this since 8.4.0 which now is a while.
There was a problem hiding this comment.
Pull request overview
Clarifies libcurl’s CURLOPT_MAXFILESIZE / CURLOPT_MAXFILESIZE_LARGE behavior so it’s clear the limit can abort both before a transfer starts (when size is known early) and during an ongoing transfer (when the limit is reached), reflecting the behavior since 8.4.0.
Changes:
- Rewords the description to explain early-abort vs in-progress abort behavior more directly.
- Adds a
HISTORYnote documenting the pre-8.4.0 behavior (no enforcement during in-progress transfers).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/libcurl/opts/CURLOPT_MAXFILESIZE.md | Updates option description for ongoing-transfer enforcement and adds a pre-8.4.0 history note. |
| docs/libcurl/opts/CURLOPT_MAXFILESIZE_LARGE.md | Mirrors the same clarification and history note for the _LARGE variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
language Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
language Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
It was not really clear, but it has worked like this since 8.4.0 which now is a while. Closes curl#21582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not really clear, but it has worked like this since 8.4.0 which now is a while.