urlapi: change more lowercase percent-encoded to uppercase#21592
Closed
bagder wants to merge 3 commits into
Closed
urlapi: change more lowercase percent-encoded to uppercase#21592bagder wants to merge 3 commits into
bagder wants to merge 3 commits into
Conversation
For consistency with other code, prefer uppercase. Verified by test 1628 Reported-by: Fabian Keil URL: https://curl.se/mail/lib-2026-05/0006.html
There was a problem hiding this comment.
Pull request overview
This PR standardizes percent-encoded triplets to use uppercase hex in the URL API output for consistency, and updates/adds regression tests to match and verify the new normalization behavior.
Changes:
- Normalize existing percent-encoded sequences to uppercase when setting URL parts without
CURLU_URLENCODE(lib/urlapi.c). - Update URL API unit test expectations to match uppercase normalization (
tests/libtest/lib1560.c). - Update an existing test expectation and add a new proxy PUT test to verify uppercase encoding in generated request URLs (
tests/data/test1221,tests/data/test1628), and register the new test in the test data makefile (tests/data/Makefile.am).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/urlapi.c | Switches normalization of percent-encoded hex to uppercase when copying raw input parts. |
| tests/libtest/lib1560.c | Adjusts URL API set/get test case to expect uppercase percent-encoding. |
| tests/data/test1221 | Updates expected request line to match uppercase percent-encoding in query building. |
| tests/data/test1628 | Adds a new regression test verifying uppercase percent-encoding in proxy absolute-form PUT request URLs. |
| tests/data/Makefile.am | Registers test1628 so it is included in the test suite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
For consistency with other code, prefer uppercase. Verified by test 1628 Reported-by: Fabian Keil URL: https://curl.se/mail/lib-2026-05/0006.html Closes curl#21592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency with other code, prefer uppercase.
Verified by test 1628
Reported-by: Fabian Keil
URL: https://curl.se/mail/lib-2026-05/0006.html