setopt: more careful cleanup of the HSTS cache#21615
Closed
bagder wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts CURLOPT_HSTS_CTRL handling so disabling HSTS does not clean up a cache owned by a share handle.
Changes:
- Adds a guard to skip HSTS cache cleanup when the easy handle uses a shared HSTS cache.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reported-by: Joshua Rogers
bagder
force-pushed
the
bagder/hsts-cleanup
branch
from
adae1b4 to
8a55a7c
Compare
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Reported-by: Joshua Rogers Closes curl#21615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Joshua Rogers