cookie: compare path case sensitively#21616
Closed
bagder wants to merge 2 commits into
Closed
Conversation
Verify with test 1645 Reported-by: Joshua Rogers
There was a problem hiding this comment.
Pull request overview
This PR updates libcurl’s cookie handling so cookie Path comparisons are performed case-sensitively, and adds a regression test to verify that cookies with the same name/domain but different-cased paths are treated as distinct entries in the cookie jar.
Changes:
- Switch cookie path comparisons in
replace_existing()from case-insensitive helpers tostrncmp/strcmp(case-sensitive). - Add new test
test1645to verify cookie-jar output preserves two cookies whose paths differ only by case. - Register
test1645in the tests data Makefile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/data/test1645 | New regression test validating distinct cookie-jar entries for same-name cookies on paths differing only by case. |
| tests/data/Makefile.am | Adds test1645 to the test list so it runs in the suite. |
| lib/cookie.c | Makes path comparison logic case-sensitive when deciding overlay/replacement behavior for existing cookies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #21616 at 9986afb3: Test 1501 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 12 different CI jobs (the link just goes to one of them). Generated by Testclutch |
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Verify with test 1645 Reported-by: Joshua Rogers Closes curl#21616
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify with test 1645
Reported-by: Joshua Rogers